From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Tue, 7 Sep 2021 06:44:28 +0000 (+0100)
Subject: Fix a crashing bug in cancel_all_RTSP_threads.
X-Git-Tag: 4.1-dev~4^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9f9513f2e3ea670e2d4831fd11d662cd53ad3913;p=thirdparty%2Fshairport-sync.git

Fix a crashing bug in cancel_all_RTSP_threads.
---

diff --git a/rtsp.c b/rtsp.c
index ba8b3fc2..244ecd44 100644
--- a/rtsp.c
+++ b/rtsp.c
@@ -651,7 +651,7 @@ void cancel_all_RTSP_threads(airplay_stream_c stream_category, int except_this_o
   debug_mutex_lock(&conns_lock, 1000000, 3);
   int i;
   for (i = 0; i < nconns; i++) {
-    if ((conns[i]->running != 0) && (conns[i]->connection_number != except_this_one) &&
+    if ((conns[i] != NULL) && (conns[i]->running != 0) && (conns[i]->connection_number != except_this_one) &&
         ((stream_category == unspecified_stream_category) ||
          (stream_category == conns[i]->airplay_stream_category))) {
       debug(1, "Connection %d: stopped.", conns[i]->connection_number);
@@ -659,7 +659,7 @@ void cancel_all_RTSP_threads(airplay_stream_c stream_category, int except_this_o
     }
   }
   for (i = 0; i < nconns; i++) {
-    if ((conns[i]->running != 0) && (conns[i]->connection_number != except_this_one) &&
+    if ((conns[i] != NULL) && (conns[i]->running != 0) && (conns[i]->connection_number != except_this_one) &&
         ((stream_category == unspecified_stream_category) ||
          (stream_category == conns[i]->airplay_stream_category))) {
       debug(1, "Connection %d: deleted.", conns[i]->connection_number);