From: Ivan Abramov Date: Mon, 10 Mar 2025 14:04:06 +0000 (+0300) Subject: smb: client: Remove redundant check in cifs_oplock_break() X-Git-Tag: v6.15-rc1~87^2~12 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9fb2e20e4f6acade2807d35cea3318786866d08d;p=thirdparty%2Fkernel%2Fstable.git smb: client: Remove redundant check in cifs_oplock_break() There is an unnecessary NULL check of inode in cifs_oplock_break(), since there are multiple dereferences of cinode prior to it. Based on usage of cifs_oplock_break() in cifs_new_fileinfo() we can safely assume that inode is not NULL, so there is no need to check inode in cifs_oplock_break() at all. Therefore, this redundant check can be removed. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Ivan Abramov Signed-off-by: Steve French --- diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c index 8582cf61242c6..66b775ae2f821 100644 --- a/fs/smb/client/file.c +++ b/fs/smb/client/file.c @@ -3082,7 +3082,7 @@ void cifs_oplock_break(struct work_struct *work) cinode->oplock = 0; } - if (inode && S_ISREG(inode->i_mode)) { + if (S_ISREG(inode->i_mode)) { if (CIFS_CACHE_READ(cinode)) break_lease(inode, O_RDONLY); else