From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Mon, 14 Jun 2021 11:16:46 +0000 (+1200)
Subject: dns scavenging: tighten lifetime of filtered records
X-Git-Tag: tevent-0.11.0~291
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9fb69274cab58ddd12f4af2cbd3deb40e42ef4d6;p=thirdparty%2Fsamba.git

dns scavenging: tighten lifetime of filtered records

We were ending up with everything lasting as long as
kccsrv_periodic_run(), which could add to quite a pile.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dsdb/kcc/scavenge_dns_records.c b/source4/dsdb/kcc/scavenge_dns_records.c
index db341364902..e31e7ec324f 100644
--- a/source4/dsdb/kcc/scavenge_dns_records.c
+++ b/source4/dsdb/kcc/scavenge_dns_records.c
@@ -196,7 +196,7 @@ static NTSTATUS dns_tombstone_records_zone(TALLOC_CTX *mem_ctx,
 			return NT_STATUS_INTERNAL_ERROR;
 		}
 
-		status = copy_current_records(mem_ctx, old_el, el, dns_timestamp);
+		status = copy_current_records(new_msg, old_el, el, dns_timestamp);
 
 		if (!NT_STATUS_IS_OK(status)) {
 			TALLOC_FREE(new_msg);