From: Jason Ish <ish@unx.ca>
Date: Mon, 28 May 2018 22:00:18 +0000 (-0600)
Subject: app-layer-detect-proto: remove unnecessary gotos
X-Git-Tag: suricata-4.1.0-rc1~61
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9fc1250ca8c3a07d4819a274a843a230954a0ac4;p=thirdparty%2Fsuricata.git

app-layer-detect-proto: remove unnecessary gotos
---

diff --git a/src/app-layer-detect-proto.c b/src/app-layer-detect-proto.c
index 6ef06d3083..cd4ad19f6c 100644
--- a/src/app-layer-detect-proto.c
+++ b/src/app-layer-detect-proto.c
@@ -1654,13 +1654,9 @@ void AppLayerProtoDetectRegisterProtocol(AppProto alproto, const char *alproto_n
 {
     SCEnter();
 
-    if (alpd_ctx.alproto_names[alproto] != NULL)
-        goto end;
-
-    alpd_ctx.alproto_names[alproto] = alproto_name;
+    if (alpd_ctx.alproto_names[alproto] == NULL)
+        alpd_ctx.alproto_names[alproto] = alproto_name;
 
-    goto end;
- end:
     SCReturn;
 }