From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 12 Oct 2023 00:40:21 +0000 (+1300)
Subject: s4:kdc: Make ‘struct user_info_dc’ members const
X-Git-Tag: talloc-2.4.2~1277
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9fcace5818a43770c2f30710fb32e0db8dd599c3;p=thirdparty%2Fsamba.git

s4:kdc: Make ‘struct user_info_dc’ members const

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 124f2e35003..25d1126f5c4 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -1133,6 +1133,7 @@ krb5_error_code samba_kdc_get_user_info_from_db(TALLOC_CTX *mem_ctx,
 	*info_out = NULL;
 
 	if (entry->info_from_db == NULL) {
+		struct auth_user_info_dc *info_from_db = NULL;
 		struct loadparm_context *lp_ctx = entry->kdc_db_ctx->lp_ctx;
 
 		nt_status = authsam_make_user_info_dc(entry,
@@ -1144,13 +1145,15 @@ krb5_error_code samba_kdc_get_user_info_from_db(TALLOC_CTX *mem_ctx,
 						      msg,
 						      data_blob_null,
 						      data_blob_null,
-						      &entry->info_from_db);
+						      &info_from_db);
 		if (!NT_STATUS_IS_OK(nt_status)) {
 			DBG_ERR("Getting user info for PAC failed: %s\n",
 				nt_errstr(nt_status));
 			/* NT_STATUS_OBJECT_NAME_NOT_FOUND is mapped to ENOENT. */
 			return map_errno_from_nt_status(nt_status);
 		}
+
+		entry->info_from_db = info_from_db;
 	}
 
 	*info_out = entry->info_from_db;
diff --git a/source4/kdc/samba_kdc.h b/source4/kdc/samba_kdc.h
index 70feae38f47..d1100f657a4 100644
--- a/source4/kdc/samba_kdc.h
+++ b/source4/kdc/samba_kdc.h
@@ -62,9 +62,9 @@ struct samba_kdc_entry {
 	struct ldb_dn *realm_dn;
 	struct claims_data *claims_from_pac;
 	struct claims_data *claims_from_db;
-	struct auth_user_info_dc *info_from_pac;
-	struct PAC_DOMAIN_GROUP_MEMBERSHIP *resource_groups_from_pac;
-	struct auth_user_info_dc *info_from_db;
+	const struct auth_user_info_dc *info_from_pac;
+	const struct PAC_DOMAIN_GROUP_MEMBERSHIP *resource_groups_from_pac;
+	const struct auth_user_info_dc *info_from_db;
 	const struct authn_kerberos_client_policy *client_policy;
 	const struct authn_server_policy *server_policy;
 	uint32_t supported_enctypes;