From: Robbie Harwood <rharwood@redhat.com>
Date: Fri, 30 Aug 2019 15:19:52 +0000 (-0400)
Subject: Remove null check in krb5_gss_duplicate_name()
X-Git-Tag: krb5-1.18-beta1~60
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9fd7bc179f0bd74fc83c1edf0247dcfd87fc73e6;p=thirdparty%2Fkrb5.git

Remove null check in krb5_gss_duplicate_name()

Within the krb5 mechanism, we require minor_status to be writable
without checking.  Remove the null check in krb5_gss_duplicate_name()
to squash a forward-null defect.
---

diff --git a/src/lib/gssapi/krb5/duplicate_name.c b/src/lib/gssapi/krb5/duplicate_name.c
index b88d97d9d6..ea53e9c0d6 100644
--- a/src/lib/gssapi/krb5/duplicate_name.c
+++ b/src/lib/gssapi/krb5/duplicate_name.c
@@ -34,8 +34,7 @@ krb5_gss_duplicate_name(OM_uint32 *minor_status, const gss_name_t input_name,
     krb5_error_code code;
     krb5_gss_name_t princ, outprinc;
 
-    if (minor_status)
-        *minor_status = 0;
+    *minor_status = 0;
 
     code = krb5_gss_init_context(&context);
     if (code) {