From: Tobias Oetiker <tobi@oetiker.ch>
Date: Tue, 11 Aug 2009 14:00:57 +0000 (+0000)
Subject: fix freeing order when generating error messages. found by Dmitry V. Krivenok
X-Git-Tag: 1.4.0~56
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9fdeee95218e3544ba7b2fc37b51f7e538f981e0;p=thirdparty%2Frrdtool-1.x.git

fix freeing order when generating error messages. found by Dmitry V. Krivenok


git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1889 a5681a0c-68f1-0310-ab6d-d61299d08faa
---

diff --git a/src/rrd_restore.c b/src/rrd_restore.c
index 4cbc37ad..46a79b5a 100644
--- a/src/rrd_restore.c
+++ b/src/rrd_restore.c
@@ -294,13 +294,14 @@ static int get_xml_double(
         }        
         errno = 0;
         temp = strtod((char *)text,NULL);
-        xmlFree(text);        
         if (errno>0){
             rrd_set_error("ling %d: get_xml_double from '%s' %s",
                           xmlTextReaderGetParserLineNumber(reader),
                           text,rrd_strerror(errno));
+            xmlFree(text);        
             return -1;
         }
+        xmlFree(text);        
         *value = temp;
         return 0;
     }