From: Ricardo Ungerer Date: Tue, 20 Jan 2026 19:47:20 +0000 (+0000) Subject: yocto-check-layer: Add messages in test_readme assertions X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9fe883ce4c6284f1b75031adafeeafb47e56958c;p=thirdparty%2Fopenembedded%2Fopenembedded-core.git yocto-check-layer: Add messages in test_readme assertions Assertions in test_readme does not provide context message when they fail. Which leads to errors like: File "/media/workspace/yocto_master/openembedded-core/scripts/lib/checklayer/cases/common.py", line 41, in test_readme self.assertTrue(email_regex.match(data)) AssertionError: None is not true This patch adds context messages to the assertions to help identify the issue when they fail. Signed-off-by: Ricardo Ungerer Signed-off-by: Richard Purdie --- diff --git a/scripts/lib/checklayer/cases/common.py b/scripts/lib/checklayer/cases/common.py index ddead69a7b..0114481434 100644 --- a/scripts/lib/checklayer/cases/common.py +++ b/scripts/lib/checklayer/cases/common.py @@ -32,13 +32,14 @@ class CommonCheckLayer(OECheckLayerTestCase): # If a layer's README references another README, then the checks below are not valid if re.search('README', data, re.IGNORECASE): + print("Layer README references another README; skipping further README checks.") return - self.assertIn('maintainer', data.lower()) - self.assertIn('patch', data.lower()) + self.assertIn('maintainer', data.lower(), msg="No maintainer info found in README.") + self.assertIn('patch', data.lower(), msg="No patching information found in README.") # Check that there is an email address in the README email_regex = re.compile(r"[^@]+@[^@]+") - self.assertTrue(email_regex.match(data)) + self.assertTrue(email_regex.match(data), msg="No email address found in README.") def find_file_by_name(self, globs): """