From: Thomas Parrott <thomas.parrott@canonical.com>
Date: Wed, 15 Jan 2020 09:33:31 +0000 (+0000)
Subject: network: Restore fixed MTU functionality
X-Git-Tag: lxc-4.0.0~58^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a00fbab5805f3f3afa5b87e1a3031989624c7043;p=thirdparty%2Flxc.git

network: Restore fixed MTU functionality

If MTU setting is provided in network device config then always use it rather than inheriting from the link device.

Affected both bridge and router veth modes.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
---

diff --git a/src/lxc/network.c b/src/lxc/network.c
index c8f44dd80..7b9ea1f25 100644
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -273,7 +273,7 @@ static int lxc_is_ip_forwarding_enabled(const char *ifname, int family)
 static int instantiate_veth(struct lxc_handler *handler, struct lxc_netdev *netdev)
 {
 	int err;
-	unsigned int mtu;
+	unsigned int mtu = 1500;
 	char *veth1, *veth2;
 	char veth1buf[IFNAMSIZ], veth2buf[IFNAMSIZ];
 
@@ -302,8 +302,10 @@ static int instantiate_veth(struct lxc_handler *handler, struct lxc_netdev *netd
 	if (!veth2)
 		return -1;
 
-	if (netdev->mtu && lxc_safe_uint(netdev->mtu, &mtu)) {
-		return log_error_errno(-1, errno, "Failed to parse mtu");
+	/* if mtu is specified in config then use that, otherwise inherit from link device if provided. */
+	if (netdev->mtu) {
+		if (lxc_safe_uint(netdev->mtu, &mtu))
+			return log_error_errno(-1, errno, "Failed to parse mtu");
 	} else if (netdev->link[0] != '\0') {
 		int ifindex_mtu;