From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 17 Jan 2021 13:38:29 +0000 (-0500)
Subject: better error messages
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a0415bbb94db0411df9a81fcc69fd5739623b0aa;p=thirdparty%2Ffreeradius-server.git

better error messages
---

diff --git a/src/protocols/tacacs/decode.c b/src/protocols/tacacs/decode.c
index c5d80eb4656..3f9726e0c46 100644
--- a/src/protocols/tacacs/decode.c
+++ b/src/protocols/tacacs/decode.c
@@ -443,7 +443,7 @@ ssize_t fr_tacacs_decode(TALLOC_CTX *ctx, uint8_t const *buffer, size_t buffer_l
 
 		} else {
 		unknown_packet:
-			fr_strerror_const("Unknown packet type");
+			fr_strerror_const("Unknown authentication packet");
 			goto fail;
 		}
 		break;
diff --git a/src/protocols/tacacs/encode.c b/src/protocols/tacacs/encode.c
index 60929581206..680691efa36 100644
--- a/src/protocols/tacacs/encode.c
+++ b/src/protocols/tacacs/encode.c
@@ -350,8 +350,8 @@ ssize_t fr_tacacs_encode(fr_dbuff_t *dbuff, uint8_t const *original_packet, char
 
 			goto check_reply;
 		}
-	unknown_packet:
-		fr_strerror_const("decode: Unknown packet type");
+
+		fr_strerror_const("encode: Unknown authentication packet type");
 		return -1;
 
 	case FR_TAC_PLUS_AUTHOR:
@@ -488,7 +488,9 @@ ssize_t fr_tacacs_encode(fr_dbuff_t *dbuff, uint8_t const *original_packet, char
 			goto check_reply;
 
 		}
-		goto unknown_packet;
+
+		fr_strerror_const("encode: Unknown authorization packet type");
+		return -1;
 
 	case FR_TAC_PLUS_ACCT:
 		if (packet_is_acct_request(packet)) {
@@ -631,10 +633,12 @@ ssize_t fr_tacacs_encode(fr_dbuff_t *dbuff, uint8_t const *original_packet, char
 			packet->hdr.seq_no &= 0xfe;
 			break;
 		}
-		goto unknown_packet;
+
+		fr_strerror_const("encode: Unknown accounting packet type");
+		return -1;
 
 	default:
-		fr_strerror_printf("encode: TACACS+ type %u", packet->hdr.type);
+		fr_strerror_printf("encode: unknown packet type %u", packet->hdr.type);
 		return -1;
 	}