From: Stefano Lattarini Date: Mon, 6 Dec 2010 21:19:36 +0000 (+0100) Subject: Merge branch 'tests-set-e-enable-1' X-Git-Tag: ng-0.5a~316 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a06fad53c65346e8b209de31b3a58c1b3fcba1a2;p=thirdparty%2Fautomake.git Merge branch 'tests-set-e-enable-1' --- a06fad53c65346e8b209de31b3a58c1b3fcba1a2 diff --cc ChangeLog index 939ef824f,d0bf4fef2..187a029b3 --- a/ChangeLog +++ b/ChangeLog @@@ -1,475 -1,46 +1,515 @@@ + 2010-11-11 Stefano Lattarini + + Enable `set -e' in more tests (plus some tweakings). + * tests/implicit.test: Enable `errexit' shell flag, and related + changes. Add trailing `:' command. + * tests/insh2.test: Likewise. + * tests/instman2.test: Likewise. + * tests/interp.test: Likewise. + * tests/interp2.test: Likewise. + * tests/library.test: Likewise. + * tests/mclean.test: Likewise. + * tests/info.test: Enable `errexit' shell flag, and related + changes. Add trailing `:' command. Remove useless chaff from + generated Makefile.am. Add a "FIXME" comment. + * tests/include.test: Enable `errexit' shell flag, and related + changes. Add trailing `:' command. Prefer cat + here-doc over + echo to append to configure.in. Make tests more robust by using + longer and less common names to grep. Remove an useless call to + echo. Remove an useless subshell. + * tests/header.test: Enable `errexit' shell flag, and related + changes. Use proper m4 quoting. Add excerpts from the original + report of the bug tested for by this script. + * tests/gcj.test: Enable `errexit' shell flag, and related + changes. Use proper m4 quoting. Add trailing `:' command. + * tests/gcj3.test: Likewise. + * tests/ldflags.test: Likewise. + * tests/libtool.test: Likewise. + * tests/listval.test: Likewise. + * tests/javaprim.test: Likewise, and prefer cat + here-doc over + echo to append to configure.in. + * tests/javasubst.test: Likewise. + * tests/discorver.test: Enable `errexit' shell flag. Prefer + trailing `:' over trailing `Exit 0'. + * tests/instdat.test: Enable `errexit' shell flag, and related + changes. Use proper m4 quoting. Avoid usless subshell. Prefer + cat + here-doc over echo to append to configure.in. + * tests/libtool2.test: Enable `errexit' shell flag, and related + changes. Add trailing `:' command. Use the configure.in + stub provided by ./defs, rather than writing it from scratch. + +2010-11-25 Stefano Lattarini + + Modernize, improve and/or tweak some test scripts. + * tests/maintclean.test: Use proper m4 quoting. Add trailing `:' + command. + * tests/sinclude.test: Likewise, and add a couple of blank lines, + for clarity. + * tests/make.test: Move setting of `errexit' shell flag earlier in + the script (just after inclusion of ./defs). Use the configure.in + stub created by ./defs, rather than writing it from scratch. Some + cosmetic changes in spacing. Ensure we wait enough time before + touching configure.in to trigger the rebuild rules. + * tests/makej.test: Use `$me' instead of hard-coding the test + name. Add trailing `:' command. + * tests/version7.test: Likewise. + * tests/space.test: Enable `errexit' shell flag, and related + changes. + * tests/makevars.test: Likewise. Also, prefer trailing `:' over + trailing `Exit 0', and be more tolerant of white spaces when + grepping Makefile.in. + +2010-12-02 Stefano Lattarini + + * tests/silent8.test: Use "|| Exit 1" after ". ./defs". + + Enable `set -e' in more tests (plus some tweakings). + * tests/mkinstall.test: Enable `errexit' shell flag, and related + changes. Add a trailing `:' command, if needed. + * tests/mdate2.test: Likewise. + * tests/objc.test: Likewise. + * tests/noinst.test: Likewise. + * tests/outdir.test: Likewise. + * tests/number.test: Likewise. + * tests/pluseq.test: Likewise. + * tests/req.test: Likewise. + * tests/rulepat.test: Likewise. + * tests/specflg6.test: Likewise. + * tests/spell3.test: Likewise. + * tests/parse.test: Likewise, and ... + (configure.in): Use the stub created by ./defs, rather than + writing it from scratch. Remove useless calls to AC_PROG_RANLIB + and AC_OUTPUT. + * tests/mdate4.test: Likewise. + * tests/mkinstall.test: Likewise, and ... + (configure.in): ... drop useless call to `AC_OUTPUT'. + * tests/output.test: Enable `errexit' shell flag, and related + changes. Add a trailing `:' command. + (configure.in): Modernize. + * tests/output2.test: Likewise. + * tests/output3.test: Likewise. + * tests/output4.test: Likewise. + * tests/mdate3.test: Enable `errexit' shell flag, and related + changes. Prefer `$me' over hard-coded test name. Do not move + non-existent or useless files in the build auxiliary directory. + * tests/nodistdir.test: Enable `errexit' shell flag, and related + changes. Prefer trailing `:' over trailing `Exit 0'. + * tests/nodist.test: Likewise. Also, prefer cat + here-doc over + echo to create input test files, and do not create useless dummy + C source files. + * tests/nodist2.test: Likewise. + * tests/ppf77.test: Enable `errexit' shell flag, with related + changes. Add a trailing `:' command. Do not create useless + dummy source files. + * tests/spelling.test: Enable `errexit' shell flag, with related + changes. Add a trailing `:' command. Also, grep Automake error + message. + * tests/specflg3.test: Enable `errexit' shell flag, with related + changes. Avoid unportable use of `-e' option of fgrep. Prefer + trailing `:' over trailing `Exit 0'. Remove extra empty lines, + and cosmetic changes to whitespaces. + * tests/obsolete.test: Enable `errexit' shell flag, with related + changes. Improve verbosity. Other miscellanous changes. + +2010-11-30 Stefano Lattarini + + Improve and extend tests on `:=' variable assignments. + * tests/colneq.test: Avoid redundant use of variable assignments + in Makefile.am. Use command-line automake options instead of + editing AUTOMAKE_OPTIONS in Makefile.am. Make grepping of the + generated Makefile.in slightly stricter. Add a trailing `:' + command. + * tests/colneq2.test: Do not create unneeded dummy files. Run + also autoconf, ./configure and make. Add trailing `:' command. + * tests/colneq3.test: New test, similar to colneq.test, but + running also autoconf, ./configure and make. + * tests/Makefile.am (TESTS): Update. + +2010-11-26 Stefano Lattarini + + Remove long-deprecated options --Werror and --Wno-error. + These options has been deprecated at least since commit + "Release-1-6-1b-35-gc037f20", dated 2002-07-06. + * automake.in (parse_arguments): Do not recognize anymore options + `--Werror' and `--Wno-error' as synonyms of respectively `-Werror' + and `-Wno-error'. + * tests/werror.test: Update: use `-Werror' instead of `--Werror'. + * NEWS: Update. + +2010-11-25 Stefano Lattarini + + Fix spurious failures in `silent*.test' for $CC != gcc + In some tests on automake-produced silent rules, we forced the + use of gcc depmode to improve testsuite coverage; but this has + unsurprisingly led to spurious failures when some non-GNU C + compilers were used. So we are now careful to require GCC in + tests that force gcc depmode. + From reports by Ralf Wildenhues. + * silent5.test: Test removed, its content split into ... + * silent-many-generic.test, silent-many-gcc.test: ... these new + sister tests, the latter of which forces gcc depmode and lists + "gcc" in $required. + * silentlex.test: Test removed, its content split into ... + * silent-lex-generic.test, silent-lex-gcc.test: ... these new + sister tests, the latter of which forces gcc depmode and lists + "gcc" in $required. + * silentyacc.test: Test removed, its content split into ... + * silent-yacc-generic.test, silent-yacc-gcc.test: ... these new + sister tests, the latter of which forces gcc depmode and lists + "gcc" in $required. + * tests/Makefile.am (TESTS): Updated. + +2010-11-21 Stefano Lattarini + + Tests: consistently use "|| Exit 1" after ". ./defs". + * tests/autohdr.test: Use `. ./defs || Exit 1', not bare + `. ./defs', for consistency with other tests. + * tests/autohdr2.test: Likewise. + * tests/autohdr3.test: Likewise. + * tests/autohdr4.test: Likewise. + * tests/cond23.test: Likewise. + * tests/cond24.test: Likewise. + * tests/cond25.test: Likewise. + * tests/cond26.test: Likewise. + * tests/cond27.test: Likewise. + * tests/cond28.test: Likewise. + * tests/cond29.test: Likewise. + * tests/cond30.test: Likewise. + * tests/cond31.test: Likewise. + * tests/cond32.test: Likewise. + * tests/cond33.test: Likewise. + * tests/cond34.test: Likewise. + * tests/cond35.test: Likewise. + * tests/cond36.test: Likewise. + * tests/cond37.test: Likewise. + * tests/cond38.test: Likewise. + * tests/cond39.test: Likewise. + * tests/cond40.test: Likewise. + * tests/cond41.test: Likewise. + * tests/cond42.test: Likewise. + * tests/cond43.test: Likewise. + * tests/cond44.test: Likewise. + * tests/cond45.test: Likewise. + * tests/dollarvar.test: Likewise. + * tests/dollarvar2.test: Likewise. + * tests/hfs.test: Likewise. + * tests/libobj14.test: Likewise. + * tests/percent.test: Likewise. + * tests/percent2.test: Likewise. + * tests/phony.test: Likewise. + * tests/silent.test: Likewise. + * tests/silent2.test: Likewise. + * tests/silent3.test: Likewise. + * tests/silent4.test: Likewise. + * tests/silent5.test: Likewise. + * tests/silent6.test: Likewise. + * tests/silent7.test: Likewise. + * tests/silent9.test: Likewise. + * tests/silentcxx.test: Likewise. + * tests/silentf77.test: Likewise. + * tests/silentf90.test: Likewise. + * tests/silentlex.test: Likewise. + * tests/silentyacc.test: Likewise. + + Avoid useless cleaning in some `silent*.test' tests. + * tests/silentf77.test: Removed useless calls to "make clean" + and "make maintainer-clean". + * tests/silentf90.test: Likewise. + * tests/silent3.test: Removed useless call to "make distclean". + * tests/silent4.test: Likewise. + * tests/silent9.test: Likewise. + +2010-11-19 Ian Lance Taylor + + Sync config-ml.in from GCC. + * config-ml.in: Add Go support: treat GOC and GOCFLAGS like other + compiler/flag environment variables. + +2010-11-20 Stefano Lattarini + + release-stats: account for more generated tests. + * Makefile.am (release-stats): Be sure to take into account all + the generated tests, by grepping the test scripts to decide which + ones of them are automatically generated. + +2010-11-20 Stefano Lattarini + + Code cleanup after removal of option `--output-directory'. + * automake.in ($output_directory): Remove, it's unconditionally + defined to `.' and used only ... + (generate_makefile): ... in this subroutine, which now has been + edited and simplified accordingly. + + Remove obsolete automake option `--output-directory'. + This option has been deprecated since version 1.7 (2002/2003). + * automake.in ($output_directory): Define to `.' unconditionally. + (parse_arguments): Remove handling of equivalent options `-o' and + `--output-directory'. + * tests/outdir.test: Removed. + * tests/no-outdir-option.test: New test. + * tests/Makefile.am (TESTS): Updated. + * NEWS: Updated. + +2010-11-19 Stefano Lattarini + + Automake::Config: remove extra trailing semicolon. + * lib/Automake/Config.in: Remove extra trailing semicolon. + + help4.test: fix botched heading comment. + * tests/help4.test: Fixed the heading comment, since it + didn't correctly describe what checks the testcase was + supposed to perform. + + help2.test: add checks on aclocal too. + * tests/help2.test: Check that also `aclocal --version' and + `aclocal --help' work with configure.in and acinclude.m4 both + broken. + +2010-11-19 Stefano Lattarini + + New test on repeated automake options. + * tests/repeated-options.test: New test, check that automake + does not complain on repeated options, nor generate broken or + incorrect makefiles. + * tests/Makefile.am (TESTS): Updated. + +2010-11-17 Stefano Lattarini + + Fix spurious failures of silent-rules tests with Sun Fortran. + * tests/silentf77.test: Strip from the make output some verbose + messages possibly printed by the SunStudio fortran compilers, to + avoid spurious failures. Add a trailing `:' command. + * tests/silentf90.test: Likewise. + +2010-11-17 Stefano Lattarini + + Fix spurious failures of silent5.test with Sun Fortran. + * tests/silent5.test: Strip from the make output some verbose + messages possibly printed by the SunStudio fortran compilers, + to avoid spurious failures. This bug has been there from the + very first version of this test script. + +2010-11-16 Stefano Lattarini + + Fix regression in colon{5,6}.test (failures on AIX 5.3). + * tests/colon5.test: Also substitute `@SHELL@' with `$SHELL' when + post-processing the generated Makefile.in, to work around a bug + of AIX 5.3 make which doesn't allow setting the `$(SHELL)' macro + on the commend line. Calls to `$MAKE' adjusted accordingly. + * tests/colon6.test: Likewise. + Regression introduced in commit v1.11-175-gf9fe878 "Modernize, + improve and/or extend tests `colon*.test", and reported by Ralf + Wildenhues. + +2010-11-16 Stefano Lattarini + + Fix regression in ansi.test (failure on AIX 5.3). + * tests/ansi.test: Remove redundant hackish check done using a + hand-postprocessed Makefile.in. This check worked by setting + the `$(SHELL)' macro on the command line of make, but this is + not supported by the AIX 5.3 make implementation. + This bug has been lurking for a long time, and was activated by + commit v1.11-125-gc1f6cdb "Enable `errexit' shell flag in various + tests". Report by Ralf Wildenhues. + +2010-11-16 Ralf Wildenhues + + backcompat5.test: avoid '##'-style comments inside recipe commands. + * tests/backcompat5.test: Remove double-hash comments + from makefile rule commands, they are not part of the + Automake API. Fixes testsuite failure with Tru64 make. + + tests: avoid '##'-style comments inside recipe commands. + * tests/confh.test, tests/confh8.test: Remove + double-hash comments from makefile rule commands, they + are not part of the Automake API. + +2010-11-14 Ralf Wildenhues + + tests: work around dash quoting issue in case statements. + * tests/color.test, tests/color2.test: Quote variable in case + pattern, to avoid skipping tests with dash 0.5.5.1. + +2010-11-16 Peter Rosin + + Skip MSVC oriented tests if the shell is not capable. + * tests/defs: New required entry 'xsi-shell'. + * tests/ar-lib.test, tests/compile3.test, tests/compile6.test: + Require a XSI capable shell. + Reported by Ralf Wildenhues. + +2010-11-15 Peter Rosin + + compile: clear the `eat' variable earlier. + * lib/compile: Clear the `eat' variable earlier. + ($scriptversion): Update. + * tests/compile3.test: Prevent regressions. + +2010-11-14 Ralf Wildenhues + + More stable configure output from sanity check. + * m4/sanity.m4 (AM_SANITY_CHECK): Always print check line + about ensuring newer files, even if we don't actually need + to wait any more. + +2010-11-14 Ralf Wildenhues + + Rebuild menus in the manual. + * doc/automake.texi: Rebuild menus (using ^C ^U ^A in emacs). + Thanks to Ian Lance Taylor for the suggestion. + + Fix install-strip when $(STRIP) contains several words. + * lib/am/install.am (install-strip): Update comment. Use + separate sub-make invocations for empty and nonempty $(STRIP), + to fix quoting issues. + * tests/strip2.test, tests/strip3.test: New tests. + * tests/Makefile.am (TESTS): Adjust. + +2010-11-10 Ralf Wildenhues + + Fix yaccdry.test failure: require bison. + * tests/yaccdry.test: Require bison. + Found by NixOS Hydra. + +2010-11-12 Stefano Lattarini + + Fix bug in test `backcompat6.test' (MSYS portability). + * tests/backcompat6.test (Makefile.am): Grep the output from the + test program, rather than diffing it, to avoid spurious failures + on MinGW/MSYS due to LF vs. CRLF line endings. + Reported by Ralf Wildenhues. + +2010-11-13 Stefano Lattarini + + Deprecate obsolete macro AM_WITH_REGEX. + * m4/regex.m4: Document the `AM_WITH_REGEX' macro as obsolete, + and state that it should be removed two years from now. + (AM_WITH_REGEX): Raise an m4-time warning of the "obsolete" + category when this macro is used. + * doc/automake.texi (Public Macros): Move description of + `AM_WITH_REGEX' from here ... + (Obsolete Macros): ... to here, and declare it as obsolete + and "to be removed in a future version". + * tests/regex-obsolete.test: New test. + * tests/Makefile.am (TESTS): Update. + +2010-11-08 Stefano Lattarini + + Improve and extend tests on man pages support. + * tests/man.test: Enable `errexit' shell flag, and related changes. + Make grepping of generated Makefile.in slightly stricter. + * tests/man3.test: Add trailing `:' command. + * tests/man5.test: Prefer cat + here-doc over echo to append to + configure.in. + * tests/man2.test: Likewise, and add trailing `:' command. + * tests/man4.test: More thorough and consistent checking of make + error messages. Place fake `help2man' program in a new `bin' + directory rather than in `.'. Move the checks using the real + `help2man' program to ... + * tests/man6.test: ... this new test, and extend them. This test + passes with GNU make and Solaris make, still fails with BSD make. + * tests/man7.test: New test, extracted from old man4.test, which + checks for a bug in maintainer-clean w.r.t. generated manpages. + * tests/man8.test: New test, extracted from old man4.test, which + checks for a bug in distcheck w.r.t. generated manpages. Passes + with GNU make and Solaris make, still fails with BSD make. + +2010-11-08 Stefano Lattarini + + Minor improvements and extensions to various tests. + * tests/defun.test: Also run autoconf and grep the generated + configure to make sure that aclocal truly picks up all the + required macros. + * tests/compile_f_c_cxx.test: Prefer trailing `:' over trailing + `Exit 0'. Do not create useless dummy source files. Do not set + useless `$(foo_LDADD)' variable in `Makefile.am'. Do not call + useless macro `AC_F77_LIBRARY_LDFLAGS' in `configure.in'. + * tests/compile_f90_c_cxx.test: Likewise. + * tests/suffix10.test: Slightly stricter grepping of make output. + * tests/compile.test: Add trailing `:' command. + * tests/defun2.test: Likewise. + * tests/vars3.test: Likewise. + * tests/vartar.test: Likewise. + * tests/vars.test: Likewise. Also, extend test by checking + that the definition of `MY_FLAGS*' variables is preserved in + the generated `Makefile.in'. + * tests/stamph2.test: Prefer trailing `:' over trailing `Exit 0'. + Use proper m4 quoting in `configure.in'. + +2010-11-11 Stefano Lattarini + + Tests defs: improve messages for skipped tests. + * tests/defs: Give meaningful messages about the reasons of a + test skip; this is especially useful as this file is run without + verbose xtraces on. Related reorderings in the code and new + comments. + +2010-11-10 Stefano Lattarini + + Tests defs: move static definitions in a new file `defs-static'. + The new file is meant to be idempotent w.r.t. multiple inclusions. + * tests/defs.in: Removed, its contents split among ... + * tests/defs-static.in: ... this new file ... + * tests/defs: ... and this new file, including the former. + * configure.ac (AC_CONFIG_FILES): Remove `tests/defs', add + `tests/defs-static'. + (AC_CONFIG_LINKS): Add `tests/defs'. + * tests/Makefile.am ($(parallel_tests)): Update. + ($(instspc_tests)): Likewise. + * tests/.gitignore: Update. + + Tests defs: $testsbuilddir is now AC_SUBST'ed. + * tests/defs.in ($testsbuilddir): Substitute from @abs_builddir@. + Add sanity check on $testsbuilddir, similar to those on + $testsrcdir and $top_testsrcdir. + + Tests defs: do not print message "Running test $0" anymore. + * tests/defs.in: Printing the message "=== Running test $0" at + the beginning of each tests made sense when Automake used the old + test-driver, which sent all the output directly to stdout/stderr. + Now that the parallel test-driver is used, which saves output of + each test in its corresponding log file, that old message is just + useless noise. + + Tests defs: rename $curdir -> $testbuilddir + * tests/defs.in: Rename $curdir to $testbuildir, for clarity and + consistency with $testsrcdir and $top_testsrcdir. + + Tests defs: prefer "$curdir" over "`pwd`". + * tests/defs.in: We already save the value of `pwd` in $curdir + early in the file, so there no need to recalculate it later, when + the current working directory is not changed. + + Tests defs: use `$me' in more error messages. + * tests/defs.in: Also use `$me' in error messages referring to + missing `defs' or `defs.in', since that variable is now defined + before those checks. + + Tests defs: do not use `Exit' where plain `exit' suffices. + * tests/defs.in: Use "exit 77" rather than "Exit 77" to skip the + test when required libtool/gettext macros are not found, since + such skips would take place before the exit trap is installed. + + Tests defs: improve and extends comments. + * tests/defs.in: Improve and extends some comments, especially in + relation with the changes introduced by the previous reordering. + + Tests defs: various reorderings. + * tests/defs.in: Reordered various snippets of code in a + clearer way. + +2010-11-09 Stefano Lattarini + + Fix bug in test `backcompat4.test' (stale autom4te cache). + * tests/backcompat4.test: Remove stale autom4te cache directory + before re-running aclocal and automake. Also, since we are at + it, be more verbose in displaying contents of generated files, + to ease debuggability. + Reported by Ralf Wildenhues. + 2010-11-07 Stefano Lattarini - Fix a bug in variable concatanation with `+='. + Fix a bug in variable concatenation with `+='. * lib/Automake/VarDef.pm (append): Since the content of the "appended-to" variable is going to be unconditionally normalized later, simply separate the appended value with a single whitespace