From: Alejandro Colomar <alx@kernel.org>
Date: Mon, 11 Dec 2023 12:36:53 +0000 (+0100)
Subject: lib/: run_command(): Use ATTR_ACCESS() instead of /*@out@*/
X-Git-Tag: 4.15.0-rc1~47
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a070b84f2e2ff8e172aa2abe601c128bd0bbae4f;p=thirdparty%2Fshadow.git

lib/: run_command(): Use ATTR_ACCESS() instead of /*@out@*/

Link: <https://splint.org/manual/manual.html#undefined>
Cc: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/prototypes.h b/lib/prototypes.h
index 3856d7f8f..61a9db5e1 100644
--- a/lib/prototypes.h
+++ b/lib/prototypes.h
@@ -433,8 +433,9 @@ extern void spw_free (/*@out@*/ /*@only@*/struct spwd *spent);
 extern int shell (const char *file, /*@null@*/const char *arg, char *const envp[]);
 
 /* spawn.c */
-extern int run_command (const char *cmd, const char *argv[],
-                        /*@null@*/const char *envp[], /*@out@*/int *status);
+ATTR_ACCESS(write_only, 4)
+extern int run_command(const char *cmd, const char *argv[],
+                       /*@null@*/const char *envp[], int *status);
 
 /* strtoday.c */
 extern long strtoday (const char *);
diff --git a/lib/spawn.c b/lib/spawn.c
index ce1a97db0..2f930ca0a 100644
--- a/lib/spawn.c
+++ b/lib/spawn.c
@@ -17,8 +17,9 @@
 
 #include "shadowlog_internal.h"
 
-int run_command (const char *cmd, const char *argv[],
-                 /*@null@*/const char *envp[], /*@out@*/int *status)
+int
+run_command(const char *cmd, const char *argv[],
+            /*@null@*/const char *envp[], int *status)
 {
 	pid_t pid, wpid;