From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 26 Jun 2017 07:25:05 +0000 (+1200)
Subject: s4-netlogon: Escape user-supplied computer name in Bad credentials log line
X-Git-Tag: tdb-1.3.14~154
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a075b7f8ddc8bd4cd63f9dfb6759bc41c2c9362d;p=thirdparty%2Fsamba.git

s4-netlogon: Escape user-supplied computer name in Bad credentials log line

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c
index df0b730757b..b50b7a52980 100644
--- a/source4/rpc_server/netlogon/dcerpc_netlogon.c
+++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c
@@ -2011,9 +2011,9 @@ static NTSTATUS dcesrv_netr_LogonGetDomainInfo(struct dcesrv_call_state *dce_cal
 						frame);
 		DBG_ERR(("Bad credentials - "
 		         "computer[%s] remote[%s] local[%s]\n"),
-			 r->in.computer_name,
-			 remote,
-			 local);
+			log_escape(frame, r->in.computer_name),
+			remote,
+			local);
 		talloc_free(frame);
 	}
 	NT_STATUS_NOT_OK_RETURN(status);