From: Fima Shevrin <efim.shevrin@virtuozzo.com>
Date: Fri, 22 May 2026 15:49:27 +0000 (+0000)
Subject: qemu: validate: treat only real backing chains as NVRAM backingStore
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a0a2b1d2efedbdbdf1c15c1704763125583e4ec2;p=thirdparty%2Flibvirt.git

qemu: validate: treat only real backing chains as NVRAM backingStore

qemuDomainInitializePflashStorageSource() always attaches a non-NULL
src->backingStore used as an empty virStorageSource chain terminator
(type VIR_STORAGE_TYPE_NONE). qemuValidateDomainDefNvram() incorrectly
interpreted every non-NULL backingStore as a genuine backing overlay and
reported VIR_ERR_CONFIG_UNSUPPORTED, so legitimate UEFI/NVRAM setups were
rejected.

Use 'virStorageSourceHasBacking' helper as the check.

Fixes: d57630c282ae7220d8998f74b7e4fec21841797f

Signed-off-by: Fima Shevrin <efim.shevrin@virtuozzo.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 642244b62e..82ef761fb8 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -740,7 +740,7 @@ qemuValidateDomainDefNvram(const virDomainDef *def,
         return -1;
     }
 
-    if (src->backingStore) {
+    if (virStorageSourceHasBacking(src)) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                         _("backingStore is not supported with NVRAM"));
         return -1;