From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 4 Sep 2024 09:07:33 +0000 (+0100)
Subject: fr_assert does noting on NDEBUG builds
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a10d8688319fdf45cc582e9101236fed5421727a;p=thirdparty%2Ffreeradius-server.git

fr_assert does noting on NDEBUG builds

So clang scan thinks ref can be NULL
---

diff --git a/src/lib/unlang/compile.c b/src/lib/unlang/compile.c
index 090cdc591d..aaf27e09fc 100644
--- a/src/lib/unlang/compile.c
+++ b/src/lib/unlang/compile.c
@@ -1669,7 +1669,7 @@ static int define_local_variable(CONF_ITEM *ci, unlang_variable_t *var, tmpl_rul
 	 *	Copy the children over.
 	 */
 	if (fr_type_is_structural(type) && (type != FR_TYPE_GROUP)) {
-		fr_assert(ref != NULL);
+		fr_fatal_assert(ref != NULL);
 
 		if (fr_dict_attr_acopy_local(da, ref) < 0) goto fail;
 	}