From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 23 Nov 2023 17:23:40 +0000 (+0100)
Subject: varlink: add an extra assert encoding our assumption that ucred is valid here
X-Git-Tag: v256-rc1~1434^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a13518231af95e2c771b8c981068e4138ea320e3;p=thirdparty%2Fsystemd.git

varlink: add an extra assert encoding our assumption that ucred is valid here
---

diff --git a/src/shared/varlink.c b/src/shared/varlink.c
index 3f022e88bd3..52a946f8c9b 100644
--- a/src/shared/varlink.c
+++ b/src/shared/varlink.c
@@ -3018,6 +3018,8 @@ static int count_connection(VarlinkServer *server, const struct ucred *ucred) {
         server->n_connections++;
 
         if (FLAGS_SET(server->flags, VARLINK_SERVER_ACCOUNT_UID)) {
+                assert(uid_is_valid(ucred->uid));
+
                 r = hashmap_ensure_allocated(&server->by_uid, NULL);
                 if (r < 0)
                         return varlink_server_log_errno(server, r, "Failed to allocate UID hash table: %m");