From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Thu, 23 Feb 2023 13:58:29 +0000 (+0100)
Subject: nts: destroy NTS-KE client right after failed start
X-Git-Tag: 4.4-pre1~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a1406eded39e3f607f5fbc5fa3a5f8720a1e5bc1;p=thirdparty%2Fchrony.git

nts: destroy NTS-KE client right after failed start

When NKC_Start() fails (e.g. due to unreachable network), don't wait for
the next poll to destroy the client and another poll to create and start
it again.
---

diff --git a/nts_ntp_client.c b/nts_ntp_client.c
index 34412a62..5b9c687b 100644
--- a/nts_ntp_client.c
+++ b/nts_ntp_client.c
@@ -239,10 +239,9 @@ get_cookies(NNC_Instance inst)
     inst->nke = NKC_CreateInstance(&inst->nts_address, inst->name, inst->cert_set);
 
     inst->nke_attempts++;
-    update_next_nke_attempt(inst, now);
 
     if (!NKC_Start(inst->nke))
-      return 0;
+      ;
   }
 
   update_next_nke_attempt(inst, now);