From: Michal Privoznik <mprivozn@redhat.com>
Date: Thu, 18 May 2023 08:27:36 +0000 (+0200)
Subject: virDomainNumatuneNodeSpecified: Fix const correctness
X-Git-Tag: v9.4.0-rc1~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a152d856c312bf6856fda0f76636c7a2700a3e63;p=thirdparty%2Flibvirt.git

virDomainNumatuneNodeSpecified: Fix const correctness

The virDomainNumatuneNodeSpecified() function does not write into
passed @numatune pointer, it just reads from it. Therefore, the
argument should be const, which allows this function to be called
from places where virDomainNuma is already const (e.g. domain
validation code).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index be0c4572c5..dd4997c759 100644
--- a/src/conf/numa_conf.c
+++ b/src/conf/numa_conf.c
@@ -116,7 +116,7 @@ struct _virDomainNuma {
 
 
 bool
-virDomainNumatuneNodeSpecified(virDomainNuma *numatune,
+virDomainNumatuneNodeSpecified(const virDomainNuma *numatune,
                                int cellid)
 {
     if (numatune &&
diff --git a/src/conf/numa_conf.h b/src/conf/numa_conf.h
index bbb928abb2..f5a20315b6 100644
--- a/src/conf/numa_conf.h
+++ b/src/conf/numa_conf.h
@@ -210,7 +210,7 @@ int virDomainNumatuneSpecifiedMaxNode(virDomainNuma *numatune);
 bool virDomainNumatuneNodesetIsAvailable(virDomainNuma *numatune,
                                          virBitmap *auto_nodeset);
 
-bool virDomainNumatuneNodeSpecified(virDomainNuma *numatune,
+bool virDomainNumatuneNodeSpecified(const virDomainNuma *numatune,
                                     int cellid);
 
 int virDomainNumaDefParseXML(virDomainNuma *def, xmlXPathContextPtr ctxt);