From: James Jones <jejones3141@gmail.com>
Date: Fri, 29 Apr 2022 12:34:07 +0000 (-0500)
Subject: Quiet coverity (CID #1503969, #1504008) (#4475)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a1629adaf301f31837f7956f4aff6593f05b29af;p=thirdparty%2Ffreeradius-server.git

Quiet coverity (CID #1503969, #1504008) (#4475)

timestr_match() converts time from the beginning of the week in
a struct tm to minutes. Coverity doesn't consider the bounds
on those values (tm_wday and tm_hour), and thus warns of possible
overflow.
---

diff --git a/src/modules/rlm_logintime/timestr.c b/src/modules/rlm_logintime/timestr.c
index 009ac71271b..7fd4125835f 100644
--- a/src/modules/rlm_logintime/timestr.c
+++ b/src/modules/rlm_logintime/timestr.c
@@ -210,7 +210,7 @@ int timestr_match(fr_time_delta_t *out, char const *tmstr, fr_time_t when)
 	time_t t = fr_time_to_sec(when);
 
 	tm = localtime_r(&t, &s_tm);
-	now = tm->tm_wday * DAYMIN + tm->tm_hour * 60 + tm->tm_min;
+	now = (int64_t) (tm->tm_wday) * DAYMIN + (int64_t) (tm->tm_hour) * 60 + tm->tm_min;
 	tot = 0;
 	memset(bitmap, 0, sizeof(bitmap));
 	week_fill(bitmap, tmstr);