From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Wed, 21 Feb 2024 09:05:14 +0000 (+0100)
Subject: BUG/MINOR: quic: initialize msg_flags before sendmsg
X-Git-Tag: v3.0-dev4~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a17eaf7763010da953c8e98e45e345dce38a6523;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: initialize msg_flags before sendmsg

Previously, msghdr struct used for sendmsg was memset to 0. This was
updated for performance reason with each members individually defined.
This is done by the following commit :

  commit 107d6d75465419a09d90c790edb617091a04468a
  OPTIM: quic: improve slightly qc_snd_buf() internal

msg_flags is the only member unset, as sendmsg manual page reports that
it is unused. However, this caused a coverity report. In the end, it is
better to explicitely set it to 0 to avoid any future interrogations,
compiler warning or even portability issues.

This should fix coverity report from github issue #2455.

No need to backport unless above patch is.
---

diff --git a/src/quic_sock.c b/src/quic_sock.c
index 6d80b0450d..4d51ef6fde 100644
--- a/src/quic_sock.c
+++ b/src/quic_sock.c
@@ -700,6 +700,7 @@ int qc_snd_buf(struct quic_conn *qc, const struct buffer *buf, size_t sz,
 	msg.msg_iovlen = 1;
 	msg.msg_control = NULL;
 	msg.msg_controllen = 0;
+	msg.msg_flags = 0;
 
 	if (qc_test_fd(qc) && !fd_send_ready(qc->fd))
 		return 0;