From: Matthijs Mekking <matthijs@isc.org>
Date: Fri, 14 Oct 2022 14:38:25 +0000 (+0200)
Subject: Change log level when doing rekey
X-Git-Tag: v9.19.7~49^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a1d57fc8cb8f0e234bed89eedbae727bb56b4b90;p=thirdparty%2Fbind9.git

Change log level when doing rekey

This log happens when BIND checks the parental-agents if the DS has
been published. But if you don't have parental-agents set up, the list
of keys to check will be empty and the result will be ISC_R_NOTFOUND.
This is not an error, so change the log level to debug in this case.
---

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index 35b34552662..2b5f8607132 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -21567,13 +21567,15 @@ zone_rekey(dns_zone_t *zone) {
 		result = dns_zone_getdnsseckeys(zone, db, ver, now,
 						&zone->checkds_ok);
 
-		if (result != ISC_R_SUCCESS) {
-			dnssec_log(zone, ISC_LOG_ERROR,
+		if (result == ISC_R_SUCCESS) {
+			zone_checkds(zone);
+		} else {
+			dnssec_log(zone,
+				   (result == ISC_R_NOTFOUND) ? ISC_LOG_DEBUG(1)
+							      : ISC_LOG_ERROR,
 				   "zone_rekey:dns_zone_getdnsseckeys failed: "
 				   "%s",
 				   isc_result_totext(result));
-		} else {
-			zone_checkds(zone);
 		}
 
 		if (result == ISC_R_SUCCESS || result == ISC_R_NOTFOUND) {