From: Mark Wielaard Date: Fri, 16 Oct 2015 19:19:05 +0000 (+0200) Subject: elflint: Don't check shdr or TLS symbol offsets against debuginfo phdrs. X-Git-Tag: elfutils-0.165~59 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a1e17a2551ddd1b2c4853e053dc1b254440211bd;p=thirdparty%2Felfutils.git elflint: Don't check shdr or TLS symbol offsets against debuginfo phdrs. In debuginfo files the phdrs file offsets match those of the original ELF file. So the section header file offsets and the TLS symbol value offset in debuginfo files cannot be sanity checked against the phdrs file offset. The issue can be triggered with run-strip-strmerge.sh test when configured with --enable-gcov. Which will insert a .tbss section and TLS symbols that trigger the above checks. Signed-off-by: Mark Wielaard --- diff --git a/src/ChangeLog b/src/ChangeLog index 0d2b1d61f..f9e3b4a55 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,10 @@ +2015-10-16 Mark Wielaard + + * elflint.c (check_symtab): Don't check TLS symbol value against TLS + phdr offset in debuginfo files. + (check_sections): Don't try to match section offsets to phdrs offsets + in debuginfo files. + 2015-10-16 Mark Wielaard * elflint.c (check_reloc_shdr): Reject only desthdrs if they have both diff --git a/src/elflint.c b/src/elflint.c index eada4d501..7d72a1f79 100644 --- a/src/elflint.c +++ b/src/elflint.c @@ -864,7 +864,7 @@ section [%2d] '%s': symbol %zu: TLS symbol but no TLS program header entry\n"), section [%2d] '%s': symbol %zu: TLS symbol but couldn't get TLS program header entry\n"), idx, section_name (ebl, idx), cnt); } - else + else if (!is_debuginfo) { if (st_value < destshdr->sh_offset - phdr->p_offset) @@ -3955,7 +3955,8 @@ section [%2zu] '%s' is both executable and writable\n"), } } - if (ehdr->e_type != ET_REL && (shdr->sh_flags & SHF_ALLOC) != 0) + if (ehdr->e_type != ET_REL && (shdr->sh_flags & SHF_ALLOC) != 0 + && !is_debuginfo) { /* Make sure the section is contained in a loaded segment and that the initialization part matches NOBITS sections. */