From: Jakob Rossi Date: Sat, 11 Jul 2026 07:17:42 +0000 (-0400) Subject: gh-151540: Use a selector event loop in the happy-eyeballs tests (#153375) X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a1ef41ab4198db28f63fda646200b14badb96513;p=thirdparty%2FPython%2Fcpython.git gh-151540: Use a selector event loop in the happy-eyeballs tests (#153375) --- diff --git a/Lib/test/test_asyncio/test_base_events.py b/Lib/test/test_asyncio/test_base_events.py index b4fd7abed596..1622f19f0213 100644 --- a/Lib/test/test_asyncio/test_base_events.py +++ b/Lib/test/test_asyncio/test_base_events.py @@ -1092,7 +1092,11 @@ class BaseEventLoopTests(test_utils.TestCase): await asyncio.sleep(1) sock.connect(address) - loop = asyncio.new_event_loop() + # gh-151540: use a selector event loop instead of the platform + # default; the Windows proactor loop would register the mocked + # socket with a real IOCP handle instead of the mocked + # _add_reader/_add_writer below. + loop = asyncio.SelectorEventLoop() loop._add_writer = mock.Mock() loop._add_writer = mock.Mock() loop._add_reader = mock.Mock() @@ -1124,7 +1128,8 @@ class BaseEventLoopTests(test_utils.TestCase): await asyncio.sleep(1) sock.connect(address) - loop = asyncio.new_event_loop() + # gh-151540: see test_create_connection_happy_eyeballs above. + loop = asyncio.SelectorEventLoop() loop._add_writer = mock.Mock() loop._add_writer = mock.Mock() loop._add_reader = mock.Mock()