From: Nicki Křížek <nicki@isc.org>
Date: Tue, 3 Mar 2026 12:37:14 +0000 (+0100)
Subject: Log dnspython queries after .to_wire() is called
X-Git-Tag: v9.21.20~14^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a22e03f71b38674ce28cb0c026a2bb7d50d93ab7;p=thirdparty%2Fbind9.git

Log dnspython queries after .to_wire() is called

Some dns message modifications like TSIG happen only after .to_wire() is
called on the message. To ensure there isn't a discrepancy between what
has been logged and what has been sent, log the query after
dns.query.udp() is executed (which calls .to_wire() on the message).

Co-Authored-By: Štěpán Balážik <stepan@isc.org>
---

diff --git a/bin/tests/system/isctest/query.py b/bin/tests/system/isctest/query.py
index 57af8254c90..8e5878d5d75 100644
--- a/bin/tests/system/isctest/query.py
+++ b/bin/tests/system/isctest/query.py
@@ -40,6 +40,26 @@ def generic_query(
     log_query: bool = True,
     log_response: bool = True,
 ) -> Any:
+
+    def log_querymsg(exception: Exception | None = None) -> None:
+        """
+        Helper for logging query message. Call this *after* query_func() has
+        been called, as it may modify the message, e.g. with a TSIG.
+
+        If an exception is provided, it will be logged as well.
+        """
+        nonlocal log_query
+        if log_query:
+            isctest.log.debug(
+                f"isc.query.{query_func.__name__}(): query\n{message.to_text()}"
+            )
+            log_query = False  # only log query once
+
+        if exception:
+            isctest.log.debug(
+                f"isc.query.{query_func.__name__}(): the '{exception}' exception raised"
+            )
+
     if port is None:
         if query_func.__name__ == "tls":
             port = int(os.environ["TLSPORT"])
@@ -57,28 +77,30 @@ def generic_query(
         query_args["verify"] = verify
 
     res = None
+
     for attempt in range(attempts):
         log_msg = (
             f"isc.query.{query_func.__name__}(): ip={ip}, port={port}, source={source}, "
             f"timeout={timeout}, attempts left={attempts-attempt}"
         )
-        if log_query:
-            log_msg += f"\n{message.to_text()}"
-            log_query = False  # only log query on first attempt
         isctest.log.debug(log_msg)
+
+        exc = None
         try:
             res = query_func(**query_args)
         except (dns.exception.Timeout, ConnectionRefusedError) as e:
-            isctest.log.debug(
-                f"isc.query.{query_func.__name__}(): the '{e}' exception raised"
-            )
-        else:
+            exc = e
+        finally:
+            log_querymsg(exc)
+
+        if res:
             if log_response:
                 isctest.log.debug(
                     f"isc.query.{query_func.__name__}(): response\n{res.to_text()}"
                 )
             if res.rcode() == expected_rcode or expected_rcode is None:
                 return res
+
         time.sleep(1)
 
     if expected_rcode is not None: