From: Victor Julien <victor@inliniac.net>
Date: Tue, 17 Sep 2019 08:41:59 +0000 (+0200)
Subject: detect/dns.opcode: improve error reporting
X-Git-Tag: suricata-5.0.0-rc1~39
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a2356a89f7cb42c91fdf607ffe0af3ecc7df5a4b;p=thirdparty%2Fsuricata.git

detect/dns.opcode: improve error reporting
---

diff --git a/src/detect-dns-opcode.c b/src/detect-dns-opcode.c
index 1d90b0668b..68edcdca41 100644
--- a/src/detect-dns-opcode.c
+++ b/src/detect-dns-opcode.c
@@ -38,7 +38,8 @@ static int DetectDnsOpcodeSetup(DetectEngineCtx *de_ctx, Signature *s,
 
     void *detect = rs_detect_dns_opcode_parse(str);
     if (detect == NULL) {
-        SCLogNotice("Failed to parse dns.opcode: %s", str);
+        SCLogError(SC_ERR_INVALID_RULE_ARGUMENT,
+                "failed to parse dns.opcode: %s", str);
         return -1;
     }