From: NeilBrown Date: Thu, 20 Apr 2017 02:40:05 +0000 (+1000) Subject: Grow_continue_command: ensure 'content' is properly initialised. X-Git-Tag: mdadm-4.1-rc1~178 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a250ce240f245df594570a5e25398680d403af67;p=thirdparty%2Fmdadm.git Grow_continue_command: ensure 'content' is properly initialised. Grow_continue_command() call verify_reshape_position(), which assumes that info->sys_name is initialised. 'info' in verify_reshape_position() is 'content' in Grow_continue_command(). In the st->ss->external != 0 branch of that function, sysfs_init() is called to initialize content->sys_name. In the st->ss->external == 0 branch, ->sys_name is not initialized so verify_reshape_position() will not do the right thing. Signed-off-by: NeilBrown Signed-off-by: Jes Sorensen --- diff --git a/Grow.c b/Grow.c index 15f4ed12..c6967ed1 100755 --- a/Grow.c +++ b/Grow.c @@ -5002,6 +5002,7 @@ int Grow_continue_command(char *devname, int fd, goto Grow_continue_command_exit; } content = &array; + sysfs_init(content, fd, NULL); /* Need to load a superblock. * FIXME we should really get what we need from * sysfs