From: Matt Coleman <mcoleman@datto.com>
Date: Fri, 6 Nov 2020 03:32:51 +0000 (-0500)
Subject: domain_conf: make virDomainIOMMUDefFormat() void
X-Git-Tag: v6.10.0-rc1~242
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a252153391c1fad9c3537bb8cb022b838706c321;p=thirdparty%2Flibvirt.git

domain_conf: make virDomainIOMMUDefFormat() void

This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3d3e524ec7..4cea54761f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -29372,7 +29372,7 @@ virDomainDefIothreadShouldFormat(virDomainDefPtr def)
 }
 
 
-static int
+static void
 virDomainIOMMUDefFormat(virBufferPtr buf,
                         const virDomainIOMMUDef *iommu)
 {
@@ -29407,8 +29407,6 @@ virDomainIOMMUDefFormat(virBufferPtr buf,
                       virDomainIOMMUModelTypeToString(iommu->model));
 
     virXMLFormatElement(buf, "iommu", &attrBuf, &childBuf);
-
-    return 0;
 }
 
 
@@ -30384,9 +30382,8 @@ virDomainDefFormatInternalSetRootName(virDomainDefPtr def,
             return -1;
     }
 
-    if (def->iommu &&
-        virDomainIOMMUDefFormat(buf, def->iommu) < 0)
-        return -1;
+    if (def->iommu)
+        virDomainIOMMUDefFormat(buf, def->iommu);
 
     if (def->vsock &&
         virDomainVsockDefFormat(buf, def->vsock) < 0)