From: Jorge Pereira <jpereiran@gmail.com>
Date: Tue, 5 Mar 2019 21:14:42 +0000 (-0300)
Subject: ring_buffer_test: Fix fr_cond_assert() call
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a27ba49d8081a129bdcf9fa6b526b395669cedbe;p=thirdparty%2Ffreeradius-server.git

ring_buffer_test: Fix fr_cond_assert() call
---

diff --git a/src/tests/util/atomic_queue_test.c b/src/tests/util/atomic_queue_test.c
index 913b1c61895..964685eaeac 100644
--- a/src/tests/util/atomic_queue_test.c
+++ b/src/tests/util/atomic_queue_test.c
@@ -69,7 +69,7 @@ static void NEVER_RETURNS usage(void)
 	fprintf(stderr, "  -s size                set queue size.\n");
 	fprintf(stderr, "  -x                     Debugging mode.\n");
 
-	exit(EXIT_FAILURE);
+	exit(EXIT_SUCCESS);
 }
 
 int main(int argc, char *argv[])
diff --git a/src/tests/util/control_test.c b/src/tests/util/control_test.c
index 023bad834f3..8f7e4c4e9e3 100644
--- a/src/tests/util/control_test.c
+++ b/src/tests/util/control_test.c
@@ -80,7 +80,7 @@ static void NEVER_RETURNS usage(void)
 	fprintf(stderr, "  -m <messages>	  Send number of messages.\n");
 	fprintf(stderr, "  -x                     Debugging mode.\n");
 
-	exit(EXIT_FAILURE);
+	exit(EXIT_SUCCESS);
 }
 
 typedef struct {
diff --git a/src/tests/util/message_set_test.c b/src/tests/util/message_set_test.c
index 4234fb41dcf..0106102fe7e 100644
--- a/src/tests/util/message_set_test.c
+++ b/src/tests/util/message_set_test.c
@@ -190,7 +190,7 @@ static void NEVER_RETURNS usage(void)
 	fprintf(stderr, "  -t                     Touch 'packet' memory.\n");
 	fprintf(stderr, "  -x                     Debugging mode.\n");
 
-	exit(EXIT_FAILURE);
+	exit(EXIT_SUCCESS);
 }
 
 int main(int argc, char *argv[])
diff --git a/src/tests/util/ring_buffer_test.c b/src/tests/util/ring_buffer_test.c
index 3954cc1ecbc..be090129446 100644
--- a/src/tests/util/ring_buffer_test.c
+++ b/src/tests/util/ring_buffer_test.c
@@ -90,10 +90,10 @@ static void  alloc_blocks(fr_ring_buffer_t *rb, uint32_t *seed, UNUSED int *star
 		array[index] = hash;
 		p = fr_ring_buffer_reserve(rb, 2048);
 
-		if (fr_cond_assert(!p)) exit(EXIT_FAILURE);
+		if (!fr_cond_assert(p != NULL)) exit(EXIT_FAILURE);
 
 		data[index] = fr_ring_buffer_alloc(rb, hash);
-		if (fr_cond_assert(data[index] != p)) exit(EXIT_FAILURE);
+		if (!fr_cond_assert(data[index] == p)) exit(EXIT_FAILURE);
 
 		if (debug_lvl > 1) printf("%08x\t", hash);