From: Victor Julien <vjulien@oisf.net>
Date: Fri, 27 Jan 2023 19:30:20 +0000 (+0100)
Subject: flowworker: don't keep unnecessary flow reference
X-Git-Tag: suricata-7.0.0-rc1~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a2dc9a40e76ded08e084f1c11eff2140380e73ec;p=thirdparty%2Fsuricata.git

flowworker: don't keep unnecessary flow reference

Flow stream/detect/log flush packets, don't hold on to the flow
beyond the flow worker module.
---

diff --git a/src/flow-worker.c b/src/flow-worker.c
index 98e6c8210e..5e4588ff4b 100644
--- a/src/flow-worker.c
+++ b/src/flow-worker.c
@@ -406,6 +406,9 @@ static inline void FlowWorkerStreamTCPUpdate(ThreadVars *tv, FlowWorkerThreadDat
                 x->flow, x->flowflags & FLOW_PKT_TOSERVER ? STREAM_TOSERVER : STREAM_TOCLIENT);
         FLOWWORKER_PROFILING_END(x, PROFILE_FLOWWORKER_TCPPRUNE);
 
+        /* no need to keep a flow ref beyond this point */
+        FlowDeReference(&x->flow);
+
         if (timeout) {
             PacketPoolReturnPacket(x);
         } else {