From: travis%sedsystems.ca <>
Date: Thu, 13 Jan 2005 00:38:35 +0000 (+0000)
Subject: Bug 277571 : checksetup should not always output a message about checking for flags
X-Git-Tag: bugzilla-2.18~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a2e5984c76fdb288c1c2bec4ab65d7be8bf71006;p=thirdparty%2Fbugzilla.git

Bug 277571 : checksetup should not always output a message about checking for flags
Patch by Max K-A <mkanat@kerio.com>   r=vladd  a=justdave
---

diff --git a/checksetup.pl b/checksetup.pl
index 60620f3293..38dc064972 100755
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -3753,8 +3753,6 @@ if (TableExists("attachstatuses") && TableExists("attachstatusdefs")) {
 # 2004-12-13 Nick.Barnes@pobox.com bug 262268
 # Check flag type names for spaces and commas, and rename them.
 if (TableExists("flagtypes")) {
-    print "Checking flag type names for spaces and commas...\n" unless $silent;
-    
     # Get names and IDs which are broken.
     $sth = $dbh->prepare("SELECT name, id FROM flagtypes");
     $sth->execute();
@@ -3769,6 +3767,7 @@ if (TableExists("flagtypes")) {
         }
     }
     if (@badflagnames) {
+        print "Removing spaces and commas from flag names...\n";
         my ($flagname, $tryflagname);
         my $sth = $dbh->prepare("UPDATE flagtypes SET name = ? WHERE id = ?");
         foreach $flagname (@badflagnames) {
@@ -3793,8 +3792,6 @@ if (TableExists("flagtypes")) {
             delete $flagtypes{$flagname};
         }
         print "... done.\n";
-    } else {
-        print "... all flag type names are good.\n" unless $silent;
     }
 }