From: VMware, Inc <>
Date: Wed, 18 Sep 2013 03:30:58 +0000 (-0700)
Subject: Use g_debug instead of g_warning in RpcChannel_Error
X-Git-Tag: 2013.09.16-1328054~52
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a302d14e247c3acd0ce83fa5455f9e759730778c;p=thirdparty%2Fopen-vm-tools.git

Use g_debug instead of g_warning in RpcChannel_Error

With esx5.1GA Tools, when there are more two Terminal Sessions
connect to a Windows VM, each TS sould have one vmtoolsd running
but actually only max two vmtoolsd run.  The Windowds Application
Event log fills up with the warning messages of
	"[vmusr:vmusr] Error in the RPC receive loop: RpcIn: Unable to send."
repeatly until close some TS' to have max two TS connected. Some
customers had vmtoolsd crashed but some didn't.  This message is from
RpcChannel_Error.  After replace g_warning() by g_debug(), the problem
is resolved.  This is a workaround for esx5.1x.

Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
---

diff --git a/open-vm-tools/lib/rpcChannel/rpcChannel.c b/open-vm-tools/lib/rpcChannel/rpcChannel.c
index 45d9358a7..fc39540fb 100644
--- a/open-vm-tools/lib/rpcChannel/rpcChannel.c
+++ b/open-vm-tools/lib/rpcChannel/rpcChannel.c
@@ -461,7 +461,11 @@ RpcChannel_Error(void *_chan,
 {
    RpcChannelInt *chan = _chan;
    chan->rpcError = TRUE;
-   g_warning("Error in the RPC receive loop: %s.\n", status);
+   /*
+    * XXX: Workaround for PR 935520.
+    * Revert the log call to g_warning() after fixing PR 955746.
+    */
+   g_debug("Error in the RPC receive loop: %s.\n", status);
 
    if (chan->resetCheck == NULL) {
       chan->resetCheck = g_idle_source_new();