From: Stefan Eissing <stefan@eissing.org>
Date: Tue, 6 May 2025 10:59:28 +0000 (+0200)
Subject: ftp: fix bug in failed init
X-Git-Tag: curl-8_14_0~155
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a30830db78e7ed3e1b02f0f666415f8ce0a72c95;p=thirdparty%2Fcurl.git

ftp: fix bug in failed init

torture tests revealed that memory was not released correctly when FTP's
connection setup failed an allocation.

Follow-up from a2d90d4ba5076643b5af9978c4

Closes #17258
---

diff --git a/lib/ftp.c b/lib/ftp.c
index ff57a57b3e..925baf6585 100644
--- a/lib/ftp.c
+++ b/lib/ftp.c
@@ -4424,7 +4424,6 @@ static CURLcode ftp_setup_connection(struct Curl_easy *data,
   if(data->set.str[STRING_FTP_ACCOUNT]) {
     ftpc->account = strdup(data->set.str[STRING_FTP_ACCOUNT]);
     if(!ftpc->account) {
-      free(ftp);
       Curl_conn_meta_remove(conn, CURL_META_FTP_CONN);
       return CURLE_OUT_OF_MEMORY;
     }
@@ -4434,7 +4433,6 @@ static CURLcode ftp_setup_connection(struct Curl_easy *data,
       strdup(data->set.str[STRING_FTP_ALTERNATIVE_TO_USER]);
     if(!ftpc->alternative_to_user) {
       Curl_safefree(ftpc->account);
-      free(ftp);
       Curl_conn_meta_remove(conn, CURL_META_FTP_CONN);
       return CURLE_OUT_OF_MEMORY;
     }