From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Fri, 26 Mar 2021 08:03:46 +0000 (+0100)
Subject: log: dont create log file for fuzz builds
X-Git-Tag: lxc-5.0.0~245^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a30a4efae5207ec3aa9aab872db8b0bb805d391e;p=thirdparty%2Flxc.git

log: dont create log file for fuzz builds

Fixes: #3730
Fixes: https://github.com/google/oss-fuzz/issues/5509
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/log.c b/src/lxc/log.c
index 92b526689..e1473603a 100644
--- a/src/lxc/log.c
+++ b/src/lxc/log.c
@@ -513,8 +513,9 @@ static int build_dir(const char *name)
 
 static int log_open(const char *name)
 {
+	int newfd = -EBADF;
+#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
 	__do_close int fd = -EBADF;
-	int newfd;
 
 	fd = lxc_unpriv(open(name, O_CREAT | O_WRONLY | O_APPEND | O_CLOEXEC, 0660));
 	if (fd < 0)
@@ -526,7 +527,7 @@ static int log_open(const char *name)
 	newfd = fcntl(fd, F_DUPFD_CLOEXEC, STDERR_FILENO);
 	if (newfd < 0)
 		return log_error_errno(-errno, errno, "Failed to dup log fd %d", fd);
-
+#endif /* !FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION */
 	return newfd;
 }
 
@@ -821,7 +822,6 @@ int lxc_log_set_file(int *fd, const char *fname)
 	*fd = log_open(fname);
 	if (*fd < 0)
 		return -errno;
-
 	return 0;
 }