From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 9 Aug 2024 15:09:41 +0000 (-0400)
Subject: Revert "Add Coverity-only check to pacify it (CID #1604609)"
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a3176971fb5b03f535d6ced21e9b5873666e22f3;p=thirdparty%2Ffreeradius-server.git

Revert "Add Coverity-only check to pacify it (CID #1604609)"

This reverts commit aa37659f220f4d0a338ab98ad4fd3110a6082fdf.
---

diff --git a/src/lib/util/event.c b/src/lib/util/event.c
index 37f9e748c5a..5785a0ea1a0 100644
--- a/src/lib/util/event.c
+++ b/src/lib/util/event.c
@@ -497,14 +497,6 @@ static void event_fd_func_index_build(fr_event_func_map_t *map)
 			 */
 			while ((pos = fr_high_bit_pos(fflags))) {
 				pos -= 1;
-#ifdef __COVERITY__
-				/*
-				 * 	Coverity somehow doesn't realize that the loop
-				 * 	condition keeps the decrement from underflowing.
-				 * 	This Coverity-only check should reassure it.
-				 */
-				if (pos >= high) return;
-#endif
 				map->ev_to_func[pos] = entry;
 				fflags &= ~(1 << pos);
 			}