From: Ruediger Pluem <rpluem@apache.org>
Date: Mon, 3 Dec 2007 11:00:26 +0000 (+0000)
Subject: * Withdraw my comment / objection as I cannot follow my own arguments during
X-Git-Tag: 2.2.7~163
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a3365a913b45947a87dbbf1d0f6939773e788269;p=thirdparty%2Fapache%2Fhttpd.git

* Withdraw my comment / objection as I cannot follow my own arguments during
  a second review. Case I missed one dup2 call on the way what lead to my
  initial comment.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@600475 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/STATUS b/STATUS
index 96aedc4cf86..6b3cd063802 100644
--- a/STATUS
+++ b/STATUS
@@ -114,11 +114,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
      This goes all the way back to piped logs failing to run on win32.
      Not in or needed at trunk/, as apr 1.3.0 has the proper fix.
        http://people.apache.org/~wrowe/httpd-2.0-2.2-procattr-bugfix-log.c.patch
-     +1: wrowe
-     rpluem says: Is this really the correct thing to do on UNIX? I am not sure
-     if all dup2 implementation notice that both fd's are the same. Otherwise
-     they close stdout/stderr first and dup a then closed fd in stdout/stderr,
-     leaving us without stdout/stderr in the child.
+     +1: wrowe, rpluem
 
    * mod_proxy_http: Correctly forward unexpected interim (HTTP 1xx) responses
      incorporating ap_send_interim_response core API