From: Lee Duncan <lduncan@suse.com>
Date: Thu, 24 Feb 2022 17:22:23 +0000 (-0800)
Subject: fix(iscsi): remove unneeded iscsi NOP-disable code
X-Git-Tag: 057~83
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a33a8df43d33c9bdf85d7a5b7392585129a690f5;p=thirdparty%2Fdracut.git

fix(iscsi): remove unneeded iscsi NOP-disable code

Commit 7374943ae3d06 ("fix(iscsi): add support for the new iscsiadm
"no-wait" (-W) command") added some code to try to disable iscsi's
NOPs, since they are considered "bad" for an iscsi root disc,
but that code doesn't work because the session is already established
at this point. Open-iscsi will change so that it automatically
disables NOPs for the root disc, so this code can just go away.
---

diff --git a/modules.d/95iscsi/iscsiroot.sh b/modules.d/95iscsi/iscsiroot.sh
index 946cb03ec..b326111f2 100755
--- a/modules.d/95iscsi/iscsiroot.sh
+++ b/modules.d/95iscsi/iscsiroot.sh
@@ -82,15 +82,6 @@ handle_firmware() {
         if [ $_res -ne 0 ]; then
             warn "iscsiadm: Log-in to iscsi target failed"
         else
-            # get a list of connected targets
-            tgts=$(cat /sys/firmware/ibft/target*/target-name | sort -u)
-            # disable NOPs for each FW target
-            for tgt in ${tgts}; do
-                iscsiadm -m node -T "${tgt}" \
-                    --op update \
-                    --name 'node.conn[0].timeo.noop_out_interval' --value 0 \
-                    --name 'node.conn[0].timeo.noop_out_timeout' --value 0
-            done
             need_shutdown
         fi
     fi