From: Victor Julien <victor@inliniac.net>
Date: Fri, 10 Apr 2020 07:55:36 +0000 (+0200)
Subject: detect/parse: fix minor memory leak in error path
X-Git-Tag: suricata-5.0.3~51
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a33ed5b5f04065a971667af041f11f50b85d75fd;p=thirdparty%2Fsuricata.git

detect/parse: fix minor memory leak in error path

Only reachable on SCMalloc so should be unlikely to be reached.

(cherry picked from commit 5abead93259e8d0bfb3f7556b9653debe320621a)
---

diff --git a/src/detect-parse.c b/src/detect-parse.c
index a4f97563d9..8c10e0dc3f 100644
--- a/src/detect-parse.c
+++ b/src/detect-parse.c
@@ -1275,7 +1275,7 @@ Signature *SigAlloc (void)
 
     sig->init_data->smlists_tail = SCCalloc(sig->init_data->smlists_array_size, sizeof(SigMatch *));
     if (sig->init_data->smlists_tail == NULL) {
-        SCFree(sig->init_data->smlists_tail);
+        SCFree(sig->init_data->smlists);
         SCFree(sig->init_data);
         SCFree(sig);
         return NULL;