From: Mark Andrews <marka@isc.org>
Date: Wed, 27 Jun 2018 01:10:59 +0000 (+1000)
Subject: cfg_parse_boolean's REQUIRE test for ret was incomplete.
X-Git-Tag: v9.10.8rc2~2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a361eb660b6bb8ac8b7dde2f0db3d6c8f113bf78;p=thirdparty%2Fbind9.git

cfg_parse_boolean's REQUIRE test for ret was incomplete.

(cherry picked from commit f1ee5e4a166b84bc0ae23dc3eddf251a10d85fac)
---

diff --git a/lib/isccfg/parser.c b/lib/isccfg/parser.c
index 009ced30042..8e5128b1c14 100644
--- a/lib/isccfg/parser.c
+++ b/lib/isccfg/parser.c
@@ -1120,7 +1120,7 @@ cfg_parse_boolean(cfg_parser_t *pctx, const cfg_type_t *type, cfg_obj_t **ret)
 	cfg_obj_t *obj = NULL;
 
 	REQUIRE(pctx != NULL);
-	REQUIRE(ret != NULL && ret != NULL);
+	REQUIRE(ret != NULL && *ret == NULL);
 
 	UNUSED(type);