From: Ján Tomko <jtomko@redhat.com>
Date: Sat, 25 Jul 2020 07:49:38 +0000 (+0200)
Subject: conf: scheduler parser: do not hardcode element name
X-Git-Tag: v6.7.0-rc1~632
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a36b6c9a8a304852b1866e3411a07cb367918519;p=thirdparty%2Flibvirt.git

conf: scheduler parser: do not hardcode element name

When trying to parse an XML with overlapping iothread scheduler
settings, the error message was rather confusing:

   error: iothreadssched attributes 'vcpus' must not overlap

Pass the correct element name.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0f12b54575..1179a27a00 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -20024,8 +20024,8 @@ virDomainThreadSchedParseHelper(xmlNodePtr node,
 
         if (sched->policy != VIR_PROC_POLICY_NONE) {
             virReportError(VIR_ERR_XML_DETAIL,
-                           _("'%s' attributes 'vcpus' must not overlap"),
-                           elementName);
+                           _("'%s' attributes '%s' must not overlap"),
+                           elementName, attributeName);
             return -1;
         }