From: Nick Porter <nick@portercomputing.co.uk>
Date: Fri, 13 Jan 2023 16:55:30 +0000 (+0000)
Subject: Correct test for invalid list
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a36f5fb3f805cabe78b5403655c2604aa97e82b1;p=thirdparty%2Ffreeradius-server.git

Correct test for invalid list
---

diff --git a/src/lib/server/tmpl_tokenize.c b/src/lib/server/tmpl_tokenize.c
index 7c5a2465664..43b4eada1f6 100644
--- a/src/lib/server/tmpl_tokenize.c
+++ b/src/lib/server/tmpl_tokenize.c
@@ -4969,7 +4969,7 @@ void tmpl_verify(char const *file, int line, tmpl_t const *vpt)
 						     fr_type_to_str(da->type));
 			}
 
-			if (!vpt->rules.attr.list_as_attr && ((tmpl_list(vpt) == PAIR_LIST_UNKNOWN) || tmpl_list(vpt) > PAIR_LIST_STATE)) {
+			if (!vpt->rules.attr.list_as_attr && (tmpl_list(vpt) == PAIR_LIST_UNKNOWN)) {
 				fr_fatal_assert_fail("CONSISTENCY CHECK FAILED %s[%u]: TMPL_TYPE_ATTR "
 						     "attribute \"%s\" has invalid list (%s)",
 						     file, line, tmpl_attr_tail_da(vpt)->name,