From: lpsolit%gmail.com <>
Date: Sat, 21 Oct 2006 06:21:08 +0000 (+0000)
Subject: Bug 356328: $rankdir should be validated in showdependencygraph.cgi - Patch by Frédér... 
X-Git-Tag: bugzilla-2.23.4~263
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a39a4ef297b2435cbd4a4ef50d459b68c8bb6106;p=thirdparty%2Fbugzilla.git

Bug 356328: $rankdir should be validated in showdependencygraph.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=bkor a=myk
---

diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi
index e483fd0f88..2cea9b2f2d 100755
--- a/showdependencygraph.cgi
+++ b/showdependencygraph.cgi
@@ -96,7 +96,16 @@ sub AddLink {
     }
 }
 
+# The list of valid directions. Some are not proposed in the dropdrown
+# menu despite they are valid ones.
+my @valid_rankdirs = ('LR', 'RL', 'TB', 'BT');
+
 my $rankdir = $cgi->param('rankdir') || "LR";
+# Make sure the submitted 'rankdir' value is valid.
+if (lsearch(\@valid_rankdirs, $rankdir) < 0) {
+    $rankdir = 'LR';
+}
+
 my $webdotdir = bz_locations()->{'webdotdir'};
 
 if (!defined $cgi->param('id') && !defined $cgi->param('doall')) {