From: Alan T. DeKok <aland@freeradius.org>
Date: Sat, 20 Feb 2021 11:25:33 +0000 (-0500)
Subject: minor rearrangement
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a3c9ce06cfe9282fbfc43b8f29c6228a51e8b930;p=thirdparty%2Ffreeradius-server.git

minor rearrangement
---

diff --git a/src/lib/server/cf_file.c b/src/lib/server/cf_file.c
index acdd5c3eb94..ef594f1d1d5 100644
--- a/src/lib/server/cf_file.c
+++ b/src/lib/server/cf_file.c
@@ -1567,13 +1567,12 @@ static int add_pair(CONF_SECTION *parent, char const *attr, char const *value,
 	if (!cd) return 0;
 
 	rule = cf_data_value(cd);
+	if (!rule->on_read) return 0;
 
 	/*
 	 *	Do the on_read callback after adding the value.
 	 */
-	if (rule->on_read) return rule->on_read(parent, NULL, NULL, cf_pair_to_item(cp), rule);
-
-	return 0;
+	return rule->on_read(parent, NULL, NULL, cf_pair_to_item(cp), rule);
 }
 
 static fr_table_ptr_sorted_t unlang_keywords[] = {