From: Stephen Finucane <stephen@that.guru>
Date: Thu, 20 Oct 2016 07:28:54 +0000 (+0100)
Subject: models: Remove Bundle.n_patches
X-Git-Tag: v2.0.0-rc1~186
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a401c586ea821ae295e72f00a436ed5e957d20fe;p=thirdparty%2Fpatchwork.git

models: Remove Bundle.n_patches

It doesn't really do much for us. Less LOC = win.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Reviewed-by: Daniel Axtens <dja@axtens.net>
---

diff --git a/patchwork/models.py b/patchwork/models.py
index 6f3257f9..51f97450 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -570,9 +570,6 @@ class Bundle(models.Model):
     patches = models.ManyToManyField(Patch, through='BundlePatch')
     public = models.BooleanField(default=False)
 
-    def n_patches(self):
-        return self.patches.all().count()
-
     def ordered_patches(self):
         return self.patches.order_by('bundlepatch__order')
 
diff --git a/patchwork/templates/patchwork/bundles.html b/patchwork/templates/patchwork/bundles.html
index 2eebd262..45bdec51 100644
--- a/patchwork/templates/patchwork/bundles.html
+++ b/patchwork/templates/patchwork/bundles.html
@@ -27,7 +27,7 @@
     <a href="{{ bundle.public_url }}">{{ bundle.public_url }}</a>
    {% endif %}
   </td>
-  <td style="text-align: right">{{ bundle.n_patches }}</td>
+  <td style="text-align: right">{{ bundle.patches.count }}</td>
   <td style="text-align: center;"><a
    href="{% url 'bundle-mbox' username=bundle.owner.username bundlename=bundle.name %}"
    ><img src="{% static "images/16-em-down.png" %}" width="16" height="16" alt="download"
diff --git a/patchwork/views/xmlrpc.py b/patchwork/views/xmlrpc.py
index cfb80d3a..30829e7f 100644
--- a/patchwork/views/xmlrpc.py
+++ b/patchwork/views/xmlrpc.py
@@ -311,7 +311,7 @@ def bundle_to_dict(obj):
     return {
         'id': obj.id,
         'name': obj.name,
-        'n_patches': obj.n_patches(),
+        'n_patches': obj.patches.count(),
         'public_url': obj.public_url(),
     }