From: Martin Schwenke <martin@meltin.net>
Date: Mon, 27 Aug 2018 05:28:47 +0000 (+1000)
Subject: ctdb-daemon: Improve error handling consistency
X-Git-Tag: samba-4.8.6~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a4021fb56d8891728ae6c4ed84f79f66d6d9ef92;p=thirdparty%2Fsamba.git

ctdb-daemon: Improve error handling consistency

Other errors free argv, so do it here too.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13592

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
(cherry picked from commit e357b62fe556609750bdb8d27cf48dfb85c62ec8)
---

diff --git a/ctdb/server/eventscript.c b/ctdb/server/eventscript.c
index 41807ffdcb0..74f132c0e80 100644
--- a/ctdb/server/eventscript.c
+++ b/ctdb/server/eventscript.c
@@ -219,6 +219,7 @@ int ctdb_start_eventd(struct ctdb_context *ctdb)
 	if (pid == -1) {
 		close(fd[0]);
 		close(fd[1]);
+		talloc_free(argv);
 		return -1;
 	}