From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Date: Fri, 11 Aug 2023 13:14:26 +0000 (+0200)
Subject: gpio: sim: simplify gpio_sim_device_config_live_store()
X-Git-Tag: v6.6-rc1~164^2~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a40fe1ffb69b709835a0623959f95d6c81ff38c1;p=thirdparty%2Fkernel%2Flinux.git

gpio: sim: simplify gpio_sim_device_config_live_store()

Simplify the logic when checking the current live value against the user
input.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index 1a3729eb44ebb..1fbbb49985f60 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -986,8 +986,7 @@ gpio_sim_device_config_live_store(struct config_item *item,
 
 	mutex_lock(&dev->lock);
 
-	if ((!live && !gpio_sim_device_is_live_unlocked(dev)) ||
-	    (live && gpio_sim_device_is_live_unlocked(dev)))
+	if (live == gpio_sim_device_is_live_unlocked(dev))
 		ret = -EPERM;
 	else if (live)
 		ret = gpio_sim_device_activate_unlocked(dev);