From: Frederik Harwath Date: Tue, 16 Nov 2021 15:22:29 +0000 (+0100) Subject: graphite: Accept loops without data references X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a4439ac7d05fa938aca8100f9e1b13922f57831a;p=thirdparty%2Fgcc.git graphite: Accept loops without data references It seems that the check that rejects loops without data references is only included to avoid handling non-profitable loops. Including those loops in Graphite's analysis enables more consistent diagnostic messages in OpenACC "kernels" code and does not introduce any testsuite regressions. If executing Graphite on loops without data references leads to noticeable compile time slow-downs for non-OpenACC users of Graphite, the check can be re-introduced but restricted to non-OpenACC functions. gcc/ChangeLog: * graphite-scop-detection.cc (scop_detection::harmful_loop_in_region): Remove check for loops without data references. --- diff --git a/gcc/ChangeLog.omp b/gcc/ChangeLog.omp index 8773233b4d98..1926db94dc4f 100644 --- a/gcc/ChangeLog.omp +++ b/gcc/ChangeLog.omp @@ -1,3 +1,8 @@ +2021-11-16 Frederik Harwath + + * graphite-scop-detection.cc (scop_detection::harmful_loop_in_region): + Remove check for loops without data references. + 2021-11-16 Frederik Harwath * graphite-scop-detection.cc (scop_context_loop): New function. diff --git a/gcc/graphite-scop-detection.cc b/gcc/graphite-scop-detection.cc index f4dba010bde7..c63933e5aa00 100644 --- a/gcc/graphite-scop-detection.cc +++ b/gcc/graphite-scop-detection.cc @@ -849,19 +849,6 @@ scop_detection::harmful_loop_in_region (sese_l scop) const return true; } - /* Check if all loop nests have at least one data reference. - ??? This check is expensive and loops premature at this point. - If important to retain we can pre-compute this for all innermost - loops and reject those when we build a SESE region for a loop - during SESE discovery. */ - if (! loop->inner - && ! loop_nest_has_data_refs (loop)) - { - DEBUG_PRINT (dp << "[scop-detection-fail] loop_" << loop->num - << " does not have any data reference.\n"); - return true; - } - DEBUG_PRINT (dp << "[scop-detection] loop_" << loop->num << " is harmless.\n"); }