From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Sat, 2 Oct 2010 19:23:38 +0000 (-0700)
Subject: Bug 600495: Make searching using "chfieldto" actually work again, for finding
X-Git-Tag: bugzilla-4.1.1~249
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a46cf131f0248614b048f55b30b1b92304292f01;p=thirdparty%2Fbugzilla.git

Bug 600495: Make searching using "chfieldto" actually work again, for finding
bugs that were also updated after the particular change that's being looked
for.
r=mkanat, a=mkanat (module owner)
---

diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index fa162ed1df..fa1e40131c 100644
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -1289,16 +1289,17 @@ sub _special_parse_chfield {
 
     my @charts;
     # It is always safe and useful to push delta_ts into the charts
-    # if there are any dates specified. It doesn't conflict with
+    # if there is a "from" date specified. It doesn't conflict with
     # searching [Bug creation], because a bug's delta_ts is set to
     # its creation_ts when it is created. So this just gives the
     # database an additional index to possibly choose.
+    #
+    # It's not safe to do it for "to" dates, though--"chfieldto" means
+    # "a field that changed before this date", and delta_ts could be either
+    # later or earlier than that.
     if ($date_from ne '') {
         push(@charts, ['delta_ts', 'greaterthaneq', $date_from]);
     }
-    if ($date_to ne '') {
-        push(@charts, ['delta_ts', 'lessthaneq', $date_to]);
-    }
 
     # Basically, we construct the chart like:
     #