From: Andreas Schneider <asn@samba.org>
Date: Mon, 1 Feb 2021 17:20:18 +0000 (+0100)
Subject: libndr: Use better and more clear check for empty flags
X-Git-Tag: tevent-0.11.0~1854
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a47fdd9ebb19f2d4b874808b5fbda19dce950021;p=thirdparty%2Fsamba.git

libndr: Use better and more clear check for empty flags

warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/librpc/ndr/libndr.h b/librpc/ndr/libndr.h
index fd772b9b510..25b68db3466 100644
--- a/librpc/ndr/libndr.h
+++ b/librpc/ndr/libndr.h
@@ -415,7 +415,7 @@ enum ndr_compression_alg {
 #define NDR_PULL_GET_MEM_CTX(ndr) (ndr->current_mem_ctx)
 
 #define NDR_PULL_SET_MEM_CTX(ndr, mem_ctx, flgs) do {\
-	if ( !(flgs) || (ndr->flags & flgs) ) {\
+	if ( (flgs == 0) || (ndr->flags & flgs) ) {\
 		if (!(mem_ctx)) {\
 			return ndr_pull_error(ndr, NDR_ERR_ALLOC, "NDR_PULL_SET_MEM_CTX(NULL): %s\n", __location__); \
 		}\