From: Andrew Pinski <andrew.pinski@oss.qualcomm.com>
Date: Sat, 13 Jun 2026 16:38:08 +0000 (-0700)
Subject: phiopt: Fix is_factor_profitable for debug stmts [PR125776]
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a4afea80fce5f1aafdd1174e48e9ebfc9ec8155d;p=thirdparty%2Fgcc.git

phiopt: Fix is_factor_profitable for debug stmts [PR125776]

This is a latent bug in is_factor_profitable where we would
consider a debug statement as an use for lifetime usage
afterwards. So you would get a compare debug failure in some
cases. pr125776-2.c fails since r15-4503-g8d6d6d537fdc75.

Pushed as obvious after a bootstrap/test.

	PR tree-optimization/125776

gcc/ChangeLog:

	* tree-ssa-phiopt.cc (is_factor_profitable): An
	usage in a debug stmt should be ignored.

gcc/testsuite/ChangeLog:

	* gcc.dg/torture/pr125776-1.c: New test.
	* gcc.dg/torture/pr125776-2.c: New test.

Signed-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com>
---

diff --git a/gcc/testsuite/gcc.dg/torture/pr125776-1.c b/gcc/testsuite/gcc.dg/torture/pr125776-1.c
new file mode 100644
index 00000000000..58f143d203f
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr125776-1.c
@@ -0,0 +1,21 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-fcompare-debug" } */
+/* PR tree-optimization/125776 */
+
+int a, b, d, e, f;
+long c;
+void g();
+void h() {
+  unsigned i;
+  for (;;) {
+    unsigned j = a ? a : d;
+    i += j;
+    f = b & 40 | b > 4;
+    e = a ? a : b;
+    if (e)
+      break;
+    if (j)
+      g();
+  }
+  c = i;
+}
diff --git a/gcc/testsuite/gcc.dg/torture/pr125776-2.c b/gcc/testsuite/gcc.dg/torture/pr125776-2.c
new file mode 100644
index 00000000000..6f89a5242ff
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr125776-2.c
@@ -0,0 +1,21 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-fcompare-debug" } */
+/* PR tree-optimization/125776 */
+int a, b, d, e, f;
+long c;
+void g();
+void h(int i) {
+  for (;;) {
+    i++;
+    int j = a  ? a : d;
+    i = i > 0 ? i : -i;
+    f = b & 40 | b > 4;
+    e = a ? a : b;
+    if (e)
+      break;
+    if (j)
+      g();
+  }
+  c = i;
+}
+
diff --git a/gcc/tree-ssa-phiopt.cc b/gcc/tree-ssa-phiopt.cc
index 82e67dc15d7..edb3469e4f7 100644
--- a/gcc/tree-ssa-phiopt.cc
+++ b/gcc/tree-ssa-phiopt.cc
@@ -304,6 +304,8 @@ is_factor_profitable (gimple *def_stmt, basic_block merge, const gimple_match_op
       FOR_EACH_IMM_USE_FAST (use_p, iter, arg)
 	{
 	  gimple *use_stmt = USE_STMT (use_p);
+	  if (is_gimple_debug (use_stmt))
+	    continue;
 	  basic_block use_bb = gimple_bb (use_stmt);
 	  if (dominated_by_p (CDI_DOMINATORS, merge, use_bb))
 	    {