From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Fri, 26 Jan 2018 02:14:43 +0000 (-0700)
Subject: We actually want a pointer to a NULL pointer because the value box code gets excited
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a4e1b29b022fcce882fadbac2ee04276e988f9e1;p=thirdparty%2Ffreeradius-server.git

We actually want a pointer to a NULL pointer because the value box code gets excited
---

diff --git a/src/main/xlat_eval.c b/src/main/xlat_eval.c
index 1d1bb7a50fa..2fa85a4f94d 100644
--- a/src/main/xlat_eval.c
+++ b/src/main/xlat_eval.c
@@ -801,7 +801,7 @@ xlat_action_t xlat_frame_eval(TALLOC_CTX *ctx, fr_cursor_t *out, xlat_exp_t cons
 
 		case XLAT_FUNC:
 		{
-			fr_value_box_t empty, *result = &empty;
+			fr_value_box_t *result = NULL;
 
 			XLAT_DEBUG("** [%i] %s(func) - %%{%s: }", unlang_stack_depth(request), __FUNCTION__,
 				   node->fmt);
@@ -816,8 +816,6 @@ xlat_action_t xlat_frame_eval(TALLOC_CTX *ctx, fr_cursor_t *out, xlat_exp_t cons
 				goto finish;
 			}
 
-			memset(&empty, 0, sizeof(empty));
-
 			/*
 			 *	If there's no children we can just
 			 *	call the function directly.